Closed planet-4 closed 9 months ago
I can work on this.
@Tendol go for it! 👍
@Tendol here is the ticket url if you need for more information. Also added to the PR's description.
Hi @Tendol :wave: Are you working on this? Do you require any assistance from the team?
Hello Nikos,
I am sincerely sorry, I have not had time to work on the issue.
Tenzin
On Fri, Oct 22, 2021 at 6:01 AM Nikos Roussos @.***> wrote:
Hi @Tendol https://github.com/Tendol 👋 Are you working on this? Do you require any assistance from the team?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/greenpeace/planet4/issues/117#issuecomment-949474660, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHYWM3LR3E4C3V7BBU5RMODUIEY7XANCNFSM4UQIYMDA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Hi Tenzin,
No problem. Are you still planning on working on it? If not, we'll un-assign you for now.
thanks! suzi
On Fri, Oct 22, 2021, 1:36 PM Tenzin Dolma Gyalpo @.***> wrote:
Hello Nikos,
I am sincerely sorry, I have not had time to work on the issue.
Tenzin
On Fri, Oct 22, 2021 at 6:01 AM Nikos Roussos @.***> wrote:
Hi @Tendol https://github.com/Tendol 👋 Are you working on this? Do you require any assistance from the team?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/greenpeace/planet4/issues/117#issuecomment-949474660 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AHYWM3LR3E4C3V7BBU5RMODUIEY7XANCNFSM4UQIYMDA
. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/greenpeace/planet4/issues/117#issuecomment-949911471, or unsubscribe https://github.com/notifications/unsubscribe-auth/APR5PAUP3HSK4Q2KJ27QRHLUIG4K7ANCNFSM4UQIYMDA .
Hi Suzi,
Please unassign me from the issue.
Thank you, Tenzin
On Tue, Oct 26, 2021 at 2:37 PM suzi grishpul @.***> wrote:
Hi Tenzin,
No problem. Are you still planning on working on it? If not, we'll un-assign you for now.
thanks! suzi
On Fri, Oct 22, 2021, 1:36 PM Tenzin Dolma Gyalpo @.***> wrote:
Hello Nikos,
I am sincerely sorry, I have not had time to work on the issue.
Tenzin
On Fri, Oct 22, 2021 at 6:01 AM Nikos Roussos @.***> wrote:
Hi @Tendol https://github.com/Tendol 👋 Are you working on this? Do you require any assistance from the team?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/greenpeace/planet4/issues/117#issuecomment-949474660 , or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AHYWM3LR3E4C3V7BBU5RMODUIEY7XANCNFSM4UQIYMDA
. Triage notifications on the go with GitHub Mobile for iOS <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android <
.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/greenpeace/planet4/issues/117#issuecomment-949911471 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/APR5PAUP3HSK4Q2KJ27QRHLUIG4K7ANCNFSM4UQIYMDA
.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/greenpeace/planet4/issues/117#issuecomment-952347484, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHYWM3ILEXO35AQNUBLVMPDUI4NRBANCNFSM4UQIYMDA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Make sure the Columns block is readable by Screen Readers.
Known issues so far:
Redundant links are often used in visual design but for a SR it means a link will be read two or three times, for example, in the Icons style, the column Icon and the column Title have the same link. We should hide the icon to the SR using aria-hidden.
Tasks:
LAYOUT_ICONS
conditions in this file).Help doc
Potentially affected repositories: planet4-master-theme
Testing
Add a Columns block to a page and test out the different styles with a screen reader, with images too when applicable. For the Tasks style, please also test the block on mobile as it is a very different layout. You can also check out the docs for more details.
JIRA Ticket: https://jira.greenpeace.org/browse/PLANET-5212