search

greenpeace / planet4

Built on top of Wordpress tech, Greenpeace Planet 4 powers digital platforms to engage with millions and win campaigns around the world.
https://planet4.greenpeace.org
Creative Commons Attribution Share Alike 4.0 International
67 stars 27 forks source link

PLANET-6261 Accordion: "Add button" not reachable with tab #159

Open planet-4 opened 3 years ago

planet-4 commented 3 years ago

The tab button correctly navigates you to all other elements of the block, but the "Add button" element is not reachable with tab. Instead it always jumps over it to the next element.

If you're not on the last item of an Accordion, the focus goes to the title of the next item directly if you hit tab with your cursor on the text field.

Screencast

https://user-images.githubusercontent.com/939357/126283080-ed1fde05-d002-48dd-a5f6-923e6a0e75ac.mp4

Reporter: pvincent
Sections: Accessibility, Block: Accordion

Potentially affected repositories: planet4-plugin-gutenberg-blocks

YumekaMengjiaLYU commented 3 years ago

Hi there, is the issue still unresolved? I would love to contribute!

comzeradd commented 3 years ago

Hi @YumekaMengjiaLYU, it's still unresolved, so it's all yours :)

comzeradd commented 3 years ago

Hi @YumekaMengjiaLYU :wave: Are you working on this? Do you require any assistance from the team?

YumekaMengjiaLYU commented 3 years ago

Hi Nikos @comzeradd , this month has been quite hectic for me but I've started working on this! I will notify you when I need any assistance : )

purplepaste5 commented 2 years ago

@comzeradd is this being worked on? I would enjoy contributing and this seems like a good first issue.

StaudenmannM commented 7 months ago

Hi @comzeradd, is this issue still open and relevant ? I tried to reproduce it on my side (Firefox/Linux Ubuntu) but tab is not going through accordion elements at all.. Accordion

comzeradd commented 7 months ago

Hey @StaudenmannM 👋🏻 This is probably not relevant anymore. It looks the <tab> is currently being used as a way to navigate to the sidebar and block options. But arrow keys seem to work.

StaudenmannM commented 7 months ago

@comzeradd Actually arrow keys work, except for the Add button as initially reported with Tab key :) I can start to look at it if you think that make sense, otherwise just let me know which issue I should start to investigate.