greenpeace / planet4

Built on top of Wordpress tech, Greenpeace Planet 4 powers digital platforms to engage with millions and win campaigns around the world.
https://planet4.greenpeace.org
Creative Commons Attribution Share Alike 4.0 International
64 stars 26 forks source link

PLANET-6407 Spreadsheet block: indicators are not present #164

Open planet-4 opened 2 years ago

planet-4 commented 2 years ago

Example Page

When a user wants to sort the order of the content appearing in a spreadsheet there are no indicators appearing to inform the user this is even possible.

There is also no reset option to return the table to the default view.

Screenshots

Screenshot Screenshot

Reporter: ktolen
Sections: Block: Spreadsheet

Potentially affected repositories: planet4-plugin-gutenberg-blocks

JIRA ticket: https://jira.greenpeace.org/browse/PLANET-6407

VallariAg commented 2 years ago

I would like to work on this issue.

GP-Dan-Tovbein commented 2 years ago

@VallariAg Go for it!

GP-Dan-Tovbein commented 2 years ago

@VallariAg FYI, here is the ticket url for a more information

comzeradd commented 2 years ago

Hi @VallariAg :wave: Are you working on this? Do you require any assistance from the team?

VallariAg commented 2 years ago

Sorry, I'll work on this and will ask for help when I get stuck. Sorry for the delay!

artze commented 2 years ago

Hi @comzeradd @VallariAg

If this issue is not currently being worked on, I can take this up

suzi-greenpeace commented 2 years ago

Go for it! thank you!

On Mon, Jan 31, 2022 at 6:31 PM artze @.***> wrote:

Hi @comzeradd https://github.com/comzeradd @VallariAg https://github.com/VallariAg

If this issue is not currently being worked on, I can take this up

— Reply to this email directly, view it on GitHub https://github.com/greenpeace/planet4/issues/164#issuecomment-1026391459, or unsubscribe https://github.com/notifications/unsubscribe-auth/APR5PAVP7575IQLLFDC4T4TUY4ZYZANCNFSM5FB3X6KQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- suzi grishpul Planet 4 Product Manager, Greenpeace International pronouns: they/them/theirs location: Denver, CO, USA (GMT/UTC-6)

Book some time with me on Fridays: Office Hours https://calendly.com/suzi-grishpul/office-hours

VallariAg commented 2 years ago

Hi @comzeradd @VallariAg

If this issue is not currently being worked on, I can take this up

Yes, sorry, I haven't been able to work on it. Go ahead :)

artze commented 2 years ago

Alright, I will take this up :)

artze commented 2 years ago

@comzeradd

Hi, I got a question.

At first render when the table is not sorted (like below), is there a preference on what kind of icon we should display next to the column titles? image

I'm thinking something like the following: image

+++

I'd also like to keep the new icon consistent with the existing asc / desc ArrowIcon. Would like to know your thoughts on the best way to achieve this, e.g.:

comzeradd commented 2 years ago

@magalifatome do we have a preference on how this icon should look? For reference, check the example page and sort by a column to see the sort icon.