greenpeace / planet4

Built on top of Wordpress tech, Greenpeace Planet 4 powers digital platforms to engage with millions and win campaigns around the world.
https://planet4.greenpeace.org
Creative Commons Attribution Share Alike 4.0 International
67 stars 27 forks source link

PLANET-6406 Spreadsheet block: sorting function not working as expected #165

Closed planet-4 closed 2 years ago

planet-4 commented 3 years ago

Example Page

When sorting numerical data the results do not appear in numerical order

Screenshots

Screenshot Screenshot

Reporter: ktolen
Sections: Block: Spreadsheet

Potentially affected repositories: planet4-plugin-gutenberg-blocks

victoria-miltcheva commented 3 years ago

Hi there, I'd like to contribute to this but it looks like the example page is broken: https://www-dev.greenpeace.org/international/story/49329/spreadsheet-test/.

aliya-rahmani commented 3 years ago

Hi there, I'd like to contribute to this but it looks like the example page is broken: https://www-dev.greenpeace.org/international/story/49329/spreadsheet-test/.

Here's the correct link:https://www.greenpeace.org/international/press-release/49648/who-strengthens-air-quality-guidelines-greenpeace-response/

Inwerpsel commented 3 years ago

Hey @victoria-miltcheva , thanks for letting us know. I'll check if I can set up another example. If you want to reproduce it locally already, it should work with any numerical data.

Inwerpsel commented 3 years ago

Thanks @aliya-rahmani , I just missed your message when posting my previous. That page should work too to get an example.

victoria-miltcheva commented 3 years ago

Thank you both for your help! I was able to get both https://github.com/greenpeace/planet4-plugin-gutenberg-blocks and https://github.com/greenpeace/planet4-docker-compose running, but I don't understand how to get changes made to my local planet4-plugin-gutenberg-block directory to show up in the Docker local dev environment - www.planet4.test. For example, I made a change to https://github.com/greenpeace/planet4-plugin-gutenberg-blocks/blob/master/assets/src/blocks/Spreadsheet/SpreadsheetEditorScript.js#L113 to test if the changes made to my local repo would be reflected in mytest environment (I added another list item), but this change didn't show up in the www.planet4.test post spreadsheet editor.

I asked this question here, but I don't think I worded it very well. I have planet4-plugin-gutenberg-blocks running with npm start, and I can access the site by going to http://localhost:35729/, but don't know how to test my changes from there. Screenshot from 2021-10-01 15-31-07

Inwerpsel commented 3 years ago

@victoria-miltcheva I'll help out on the Slack channel so that we can keep this ticket focused on the subject :slightly_smiling_face:

victoria-miltcheva commented 3 years ago

@Inwerpsel sounds good!