greenpeace / planet4

Built on top of Wordpress tech, Greenpeace Planet 4 powers digital platforms to engage with millions and win campaigns around the world.
https://planet4.greenpeace.org
Creative Commons Attribution Share Alike 4.0 International
67 stars 27 forks source link

PLANET-6000 Images with links open the link in a new tab and the lightbox in the old tab simultaneously. #171

Closed planet-4 closed 2 years ago

planet-4 commented 3 years ago

When a user creates an image with a link, the link opens in a new tab and the Lightbox appears in the old tab simultaneously.

It would be nice to automatically ignore the lightbox if the image has a link. Let's check if we can consistently detect that.

Tasks

Reporter: pcuadrad
Sections: Styling/Theme

Potentially affected repositories: planet4-plugin-gutenberg-blocks

JIRA ticket: https://jira.greenpeace.org/browse/PLANET-6000

aditi977 commented 3 years ago

I can try to work on this issue

GP-Dan-Tovbein commented 3 years ago

Go for it :muscle:

comzeradd commented 2 years ago

Hi @aditi977 :wave: Are you working on this? Do you require any assistance from the team?

aditi977 commented 2 years ago

Hi yes @comzeradd, I intend to continue to work on it. If I require assistance, how do I get in touch with the team? Would I just @ people?

comzeradd commented 2 years ago

You can just leave a comment here and we can follow up 👍🏻

comzeradd commented 2 years ago

We had some time to work on that, and it's now fixed at https://github.com/greenpeace/planet4-plugin-gutenberg-blocks/pull/759/commits/4e11dcb334be1817a3cb21147842653776685127