greenpeace / planet4

Built on top of Wordpress tech, Greenpeace Planet 4 powers digital platforms to engage with millions and win campaigns around the world.

https://planet4.greenpeace.org

Creative Commons Attribution Share Alike 4.0 International

66 stars 27 forks source link

PLANET-5322 Conform our shell scripts to Google Styleguide using shfmt #72

Closed comzeradd closed 4 years ago

comzeradd commented 4 years ago

Brief summary of task:

For consistency we can follow Google Shell Script Styleguide in all of our shell scripts. This is mainly for planet4-builder and planet4-circleci repositories, that hold most of our scripts.

Objectives of task:

To enforce that we can use shfmt to adjust our current scripts but also lint future changes and additions.

Tasks

Run shfmt to all of our scripts at these two folders: builder and circleci.
Expand our lint job to use shfmt along with shellcheck

r0bobo commented 4 years ago

Can I suggest reviewers for the two pull-requests or are the relevant people pinged automatically anyway?

comzeradd commented 4 years ago

Thanks @r0bobo :green_heart: I added a few relevant people as reviewers so they get the ping ;)