Golem irregularities

[GoogleCodeExporter]

playing Golem uses an action for each card it finds. if any village is found 
then you get only 1action.  but if any other is found the you end up with 
-2actions.

also Golem doubles the visual display of which card is played, not the effects 
just the card played. 
ie. if it finds a Ghost Ship and a Mengerie, it shows 2 of each after the Golem

i often use Golem to get cards or more actions depending on deck. 

Original issue reported on code.google.com by ston...@gmail.com on 3 Jan 2012 at 6:58

[GoogleCodeExporter]

Golem also adds duplicates of cards to your deck. In a Golem/Highway game, I 
bought all of the Highways and ended up with 14 Highways in my deck at the end 
of the game. 

Original comment by Theodore...@gmail.com on 3 Jan 2012 at 10:01

[GoogleCodeExporter]

I suggest changing the name of the flag "context.throneRoomsInEffect" to 
"context.freeActionInEffect" and set that flag when playing a Golem much like 
it is set in the TR/KC function. 

The visual display is a result of a duplication of 
context.playedCards.add(card); Line 158 and line 3223 both add the card to the 
played cards list. 

Also, if the card being played by Golem exists in your hand, it will be removed 
due to line 152. 

I guess to summarize, the way that .play() is called in Golem should match the 
way it is called in throneRoomKingsCourt(). Too much code duplication is going 
on there and it is causing a lot of problems.

Original comment by Theodore...@gmail.com on 4 Jan 2012 at 1:13

[GoogleCodeExporter]

This issue was closed by revision r239.

Original comment by tkdenni...@gmail.com on 4 Jan 2012 at 6:02

• Changed state: Fixed

[GoogleCodeExporter]

Thank you for the code references and the suggestion to reuse 
throneRoomsInEffect as freeActionInEffect - made the fix a lot easier :) The 
Golem is a little different than throneRoomKingsCourt since the action cards 
are coming from the deck instead of the hand. For now, I just put the selected 
action card into the hand so it could be pulled right back out as it played, 
and hid it from the UI.

Original comment by tkdenni...@gmail.com on 4 Jan 2012 at 6:08

[GoogleCodeExporter]

The only thing I worry about with adding it to the hand but hidden is the 
situation where the card to be played matches a card in the player's hand. In 
this case, is there a chance that playing the card will remove the non-hidden 
card instead of the hidden one? Thereby basically removing the card from your 
hand and not replacing it?

Original comment by Theodore...@gmail.com on 4 Jan 2012 at 7:17