Reaction dialog can be confusing -- hard to tell anything actually happened

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Opponent plays Militia.
2. A box pops up that says "Select reaction card to reveal [Militia]".
3. User clicks "Moat"
4. A box pops up that says "Select reaction card to reveal [Militia]".
5. User clicks "Moat"
6. A box pops up that says "Select reaction card to reveal [Militia]".
5. User clicks "Moat"
6. A box pops up that says "Select reaction card to reveal [Militia]".
7. User quits in frustration

What is the expected output? What do you see instead?
Right now, it can be difficult to tell that anything happens when I play a 
reaction card like Moat.  There is a line of text that says 

You: Defended Moat

but the text box is behind the reaction popup.  A Moat pops up for a second, 
but what does that mean?

Please use labels and text to provide additional information.
What's the best way to improve this user experience?  In this case, the Moat 
remains in the player's hand, so we shouldn't show it anywhere else (like on 
the table).  I don't have any particularly good suggestions.

v2.01

Original issue reported on code.google.com by August.D...@gmail.com on 11 Jan 2012 at 12:12

[GoogleCodeExporter]

If player has defended by Light House or Moat, reaction dialog doesn't contain 
Moat.
Consistency of reactions will be lost a bit.
But this is a better reaction for daily Moat question, I think.

Original comment by ksuke...@gmail.com on 11 Jan 2012 at 1:10

[GoogleCodeExporter]

How about not showing the same card twice in a row? Based on the very helpful 
description of events in issue 214, the sequence was Secret Chamber, Moat, 
Secret Chamber. The prompt could appear for any defense card in the hand, then 
any defense card in the hand _except_ for the one just played. The user could 
continue showing Secret Chamber then Moat indefinitely, but at least the prompt 
is changing to register the card played. Is there ever a situation where you 
could benefit from showing the exact same card twice in a row?

Another thought: change the "None" option to "Done" after the first defense 
card is played. Again, the prompt has changed in response to user input. 

Last, a user-option for the first idea? Then at least the game moves on, even 
if it doesn't follow isotropic's lead.

Original comment by tkdenni...@gmail.com on 11 Jan 2012 at 2:03

[GoogleCodeExporter]

I fix temporary as following:

- If already defended, Moat doesn't appear in dialog.
- Moat and Secret Chamber shows once.

Commit in r303. Please evaluate.

Original comment by ksuke...@gmail.com on 11 Jan 2012 at 2:06

[GoogleCodeExporter]

If my opponent plays Militia only one time, why should I actually see the Moat 
dialog more than once? I think the problem lies deeper, getAttackReaction 
shouldn't even be called twice.

Original comment by t.mahlm...@gmail.com on 11 Jan 2012 at 4:25

[GoogleCodeExporter]

No change should be made to Secret Chamber.  There are valid scenarios, such as 
the one detailed in my previous comment, where a player would want to play the 
same Secret Chamber twice in reaction to the same attack.

Any changes made must allow the player to play the same reaction more than once 
if there might ever be a reason to do so.

The change to prevent Moat from reappearing should be ok.

Original comment by August.D...@gmail.com on 11 Jan 2012 at 5:16

[GoogleCodeExporter]

r303 is a nice improvement! I would still prefer to not see the Secret Chamber 
again if it is the only defense card and I have already just played it - seems 
pointless to keep changing the top 2 cards if no other defense card appeared.

Original comment by tkdenni...@gmail.com on 11 Jan 2012 at 11:56

[GoogleCodeExporter]

I wouldn't change anything any further -- this is a pretty good balance between 
making things less confusing and pedantically following the rules (which we 
should favor over merely making things convenient).  

Original comment by mooht...@gmail.com on 21 Jan 2012 at 1:40

• Changed state: Fixed