Card dropping perfromance

greenpiece / androminion

Automatically exported from code.google.com/p/androminion

0 stars 0 forks source link

Card dropping perfromance #239

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Card dropping (e.g. Goons) is very slow. Also it looks like it affects sum 
cards of a player for some reason.

It would be nice to speed this up, I have to wait long for this.

Original issue reported on code.google.com by ras.na...@gmail.com on 13 Jan 2012 at 3:34

GoogleCodeExporter commented 9 years ago

"I have to wait long" is a bit of a subjective term. It feels fine to me, and 
I've got an two years old Milestone (Droid I). I'm not sure if setting up the 
animation speed or skipping them is a good idea.

Original comment by t.mahlm...@gmail.com on 13 Jan 2012 at 4:47

Added labels: Priority-Low
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

I'm also on a Droid I.  When I play Militia in a 4 player game, there's a 4.5 
to 5 second lag between when I hit the play button and when I can perform my 
next action.  (Yeah, I actually timed it.)  This is the time when my opponents 
are discarding.

I have to admit, this has always felt pretty slow to me too, especially when 
most other cards require a very small amount of time to be played (typically 
less than half a second).  Personally, I'd be happy to see the animation sped 
up or skipped.

Original comment by August.D...@gmail.com on 13 Jan 2012 at 10:23

Changed state: Accepted
Added labels: Component-UI, Type-Enhancement
Removed labels: Type-Defect

GoogleCodeExporter commented 9 years ago

I've noticed that it seems slow on most cards that involve opponents discarding 
and I have a relatively new Nexus S 4G. I would say maybe an alternative could 
be to have a menu option where you could turn off all animations for those of 
us who like to play fast. :)

Original comment by bnoble1...@gmail.com on 14 Jan 2012 at 11:29

GoogleCodeExporter commented 9 years ago

I don't think it's an animation issue, I think it's a network traffic issue.  
When cards are dropped, the cards that are meant to stay go into a temporary 
location, then the other cards are discarded, then the cards to be kept are 
added back into the hand one at a time.  Each time a card is added, there is a 
message sent to that effect, and I think it's the messsage passing that takes 
time.

I think all those notifications were added for debug purposes, so is it safe to 
remove them and have a single notification after discarding cards?

Original comment by mooht...@gmail.com on 21 Jan 2012 at 1:46

Added labels: Component-Core
Removed labels: Component-UI

GoogleCodeExporter commented 9 years ago

This issue was closed by revision r347.

Original comment by mooht...@gmail.com on 25 Jan 2012 at 12:58

Changed state: Fixed