greenplum-db / PivotalR-archive

An convenient R tool for manipulating tables in PostgreSQL type databases and a wrapper of Apache MADlib.
https://pivotalsoftware.github.io/gp-r/
125 stars 53 forks source link

Update testing process to use devtools::test #48

Closed iyerr3 closed 7 years ago

iyerr3 commented 7 years ago

Updates to the testing files. The test can now be run (after installing testthat and devtools), with command devtools::test().

The README for tests has not been updated yet.

The tests have to be run in the project root folder with devtools::test(). You can provide a filter input to the call to run only specific test file. To run the database specific tests the test needs to connect to the database. This works by creating two variables in the global environment: pivotalr_dbname and pivotalr_port with appropriate values.

iyerr3 commented 7 years ago

There seems to be some value in keeping the older way to performing testing while internally changing the test execution to use latest testthat process.

Any thoughts/comments on this?

orhankislal commented 7 years ago

LGTM +1