greenpress / vuex-composition-helpers

A util package to use Vuex with Composition API easily.
https://www.npmjs.com/package/vuex-composition-helpers
MIT License
288 stars 32 forks source link

Fix vue-cli transpile config #54

Open kaisensan opened 2 years ago

kaisensan commented 2 years ago

I believe there's an error in current vue-cli transpile config. It doesn't work as it is (at least not for me), and taking in consideration what's suggested for webpack right above, I think it should be exclude instead of include.

davidmeirlevy commented 2 years ago

@Kaisen-san It actually depends, because you can't really use both exclude and include, and it's very confusing (what happens when there's a conflict between them - what should the bundler do?). It will be great to show both cases:

kaisensan commented 2 years ago

Hello @davidmeirlevy, I'm not sure if I get your point. I was referring to this example here. The way it's described there, it seemed to me that the example below, using vue-cli, was supposed to be equivalent to that (and as such, use exclude instead of include). I only have vue.config.js in my solution, so I don't think there would be any conflicts, but I assume the behavior should be the same either using webpack.config.js or vue.config.js.