search

greenpress / vuex-composition-helpers

A util package to use Vuex with Composition API easily.
https://www.npmjs.com/package/vuex-composition-helpers
MIT License
288 stars 32 forks source link

feat: add inline namespace for global helpers #58

Closed nolde closed 2 years ago

nolde commented 2 years ago

Resolves #57

All tests are passing.

davidmeirlevy commented 2 years ago

Looks great. Can you add more tests that will cover the new API you added?

nolde commented 2 years ago

Sure!

You had tests for map, store+map, and store+namespace+map (the ones using createNamespacedHelpers), so those should still be covered by the existing ones.

I will add some more for namespace+map, which are the only ones missing.

nolde commented 2 years ago

Done!

nolde commented 2 years ago

Anything else you need from me on this one, @davidmeirlevy ?

davidmeirlevy commented 2 years ago

@nolde nothing, that's awesome! I'll publish the new version today.

also, if you can add this ability into the cloned branch of the #55 branch, that will be awesome too (this branch is having this package working for vue3).

nolde commented 2 years ago

Sure,, will take a look at that!

Might take a while longer though, with holidays coming up.

Thanks for merging!