greenriver / hmis-warehouse

The Open Path HMIS Warehouse (Warehouse) project was initiated by the City of Boston's Department of Neighborhood Development office to coordinate data across various HMIS installations and supply de-duplicated client information to the Boston CAS (https://github.com/greenriver/boston-cas).

http://openpath.host

GNU General Public License v3.0

30 stars 14 forks source link

6708 2fa fix #4748

Closed ttoomey closed 1 week ago

ttoomey commented 1 week ago

Please squash merge this PR

Description

new accounts should get a longer otp secret (u.otp_secret.size == 26)
migrating secrets on existing accounts is out of scope

https://github.com/open-path/Green-River/issues/6708

Type of change

[x] Security fix

Checklist before requesting review

[x] I have performed a self-review of my code
[x] I have run the code that is being changed under ideal conditions, and it doesn't fail
[x] My code includes comments and/or descriptive variable names to help other engineers understand the intent (or not applicable)
[x] My code follows the style guidelines of this project (rubocop)
[x] I have updated the documentation (or not applicable)
[x] If it's not obvious how to test this change, I have provided testing instructions in this PR or the related issue