greenrobot / EventBus

Event bus for Android and Java that simplifies communication between Activities, Fragments, Threads, Services, etc. Less code, better quality.
http://greenrobot.org/eventbus/
Apache License 2.0
24.67k stars 4.66k forks source link

Added manifest entry to the eventbus-java jar file #702

Open plumstone opened 2 years ago

plumstone commented 2 years ago

Solves the warning mentioned in https://github.com/greenrobot/EventBus/issues/507

greenrobot-team commented 2 years ago

Thanks! We'll have a look at some point if that is enough (note: I remember something about package names not being allowed to overlap, need to check if the Android artifact ever is supposed to use modules, too).

plumstone commented 2 years ago

The build failed due to an error in the jdk setup process. Maybe we should consider updating the jdk to temurin (successor of adopt) https://github.com/actions/setup-java#basic

greenrobot-team commented 2 years ago

@plumstone Thanks for the info! Fixed in master branch, e.g. rebase your change onto or merge the changes from master.