search

greenrobot / android-database-performance

Android Database Performance Benchmarks
Apache License 2.0
80 stars 16 forks source link

Update to SQL Delight 0.4.4 #17

Closed JakeWharton closed 7 years ago

JakeWharton commented 7 years ago

We added native support for short because we saw you were trying to use them (aside: dear god why shorts????). The docs never should have said short was supported because literally 0 people should be using it (hence why we didn't support it).

greenrobot-team commented 7 years ago

I assume it's a leftover from a long time ago, not sure. @greenrobot any reasons why the perf test includes short, can we remove it? -ut

greenrobot commented 7 years ago

The idea just was to cover basic types. I'd like to keep the testing scenario the same - we used it for years and this way it stays stable.

greenrobot commented 7 years ago

P.S. @JakeWharton: Did it have any effect? Would be surprised if this makes any difference, SQLite doesn't care anyway.

JakeWharton commented 7 years ago

It'll avoid boxing through your custom ColumnAdapter so you get less garbage on the heap and less GC pressure.

On Mon, Aug 8, 2016, 3:14 AM greenrobot notifications@github.com wrote:

P.S. @JakeWharton https://github.com/JakeWharton: Did it have any effect? Would be surprised if this makes any difference, SQLite doesn't care anyway.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/greenrobot/android-database-performance/issues/17#issuecomment-238158524, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEVcNY3YUrZq0AflzCw8h6KfeS-qnks5qdtc7gaJpZM4Jc56s .