search

greenrobot / android-database-performance

Android Database Performance Benchmarks
Apache License 2.0
80 stars 16 forks source link

Add SQLCipher support. #24

Closed raiym closed 4 years ago

raiym commented 4 years ago

https://github.com/sqlcipher/android-database-sqlcipher

raiym commented 4 years ago

@greenrobot if this library is still maintained I could add SQLCipher PR.

greenrobot commented 4 years ago

You want to add a "greenDAO&SQLCipher" option to the benchmarking app?

raiym commented 4 years ago

@greenrobot not sure if correctly I understand you. greenDAO already there and SQLCipher is not.

I integrated SQLCipher benchmarking tests as new module, they are the same as SQLite tests that presented in repository but SQLCipher classes are used instead of SQLite classes. Since SQLCipher is somewhat popular within Android community I think that including this test will make library better.

greenrobot commented 4 years ago

Ah OK so not "greenDAO&SQLCipher" but plain SQL using SQLCipher...

Could you post the results here? Is the difference significant?

raiym commented 4 years ago

@greenrobot yes, correct.

I made the changes and created PR, I wrote about what I did in PR description:

https://github.com/greenrobot/android-database-performance/pull/25

Could you please check and provide feedback?

greenrobot-team commented 4 years ago

Support added with #27.

Also has some quick results. https://github.com/greenrobot/android-database-performance/pull/27#issuecomment-596985359