search

greensock / GSAP

GSAP (GreenSock Animation Platform), a JavaScript animation library for the modern web
https://gsap.com
19.83k stars 1.72k forks source link

The arguments are useless #16

Closed 12d closed 11 years ago

12d commented 11 years ago

p._kill = function(vars, target) { return this._enabled(false, false); };

    p.kill = function(vars, target) {
        this._kill(vars, target);
        return this;
    };

these methods in 'Animate', arguments are not used.

jackdoyle commented 11 years ago

Those are in there for inheritance reasons - the parameters aren't used in the Animation._kill() method, but it is in the TweenLite._kill() method (and others). Keep in mind that Animation is a base class for TweenLite, TweenMax, TimelineLite and TimelineMax.