greensock / GreenSock-AS3

Public repository for GreenSock's ActionScript 3 libraries like GSAP (TweenLite, TweenMax, etc.) and LoaderMax. For AS2, see the GreenSock-AS2 repository and for JavaScript, see the GreenSock-JS repository. Main site: http://www.greensock.com
409 stars 144 forks source link

Timestamp vs Math.random #7

Closed matthaliski closed 10 years ago

matthaliski commented 10 years ago

I'm curious if it would be detrimental to swap out the Math.random() on line 180 of LoaderItem.as with a timestamp down to the second? It accomplishes a certain randomness which I believe is the goal of that particular line.

The Google Display Network doesn't allow the use of Math.random(). They somehow decompile the swf and crawl for that method in particular and block the upload. I've made my own fix and it seems to work fine. But, I feel icky modifying the core.

What are your thoughts? Does it incur any extra overhead?

jackdoyle commented 10 years ago

Yes, I think this is doable, sure. Thanks for the suggestion. We'll drop it into the next update.