search

greenstack / spite-framework

The Spite Framework is a C# library meant to simplify designing and implementing turn-based gameplay by providing some boilerplate code.
MIT License
6 stars 0 forks source link

Team/Side naming is inconsistent #1

Closed greenstack closed 4 years ago

greenstack commented 4 years ago

The way it stands now, Teams and Sides are used interchangeably in the framework. This isn't ideal, since everywhere where Sides is used, an ITeam object is expected.

In the framework itself, the phase "Side" occurs ~20 times; "Team" occurs far more frequently. Since "Side" variables and methods accept ITeam objects, I believe it would be better to replace the term "Side" with "Team". This way, we can also reserve the term "Side" for something different in the future if need be.

greenstack commented 4 years ago

There's only really one reference to side left, and it's in a context where team is already being used. I think it's okay, so I'm giving this issue the all-clear for closing.