greentfrapp / lucent

Lucid library adapted for PyTorch
Apache License 2.0
597 stars 89 forks source link

Add direction and direction_neuron objectives #6

Closed ndey96 closed 4 years ago

ndey96 commented 4 years ago

Hi @greentfrapp,

Thanks so much for making this repo! It has been a great help for me. For my use-case I needed the direction and direction_neuron objectives so I added them into lucent. I also included two demo files but let me know if they should be rolled into a docstring instead. This PR also lays the groundwork to reproduce the activation atlas notebooks from lucid. Would love to hear your thoughts :)

greentfrapp commented 4 years ago

Thank you @ndey96 for the contribution and I'm really glad that you found the library helpful!

The new direction objectives look good! Just a few quick things

We should be good to merge after that!

ndey96 commented 4 years ago

@greentfrapp Addressed your comments :) I noticed that a few other PRs were recently merged. Is it possible to bump the version on PyPI once this gets merged?

Thanks!

greentfrapp commented 4 years ago

Awesome thank you @ndey96 I'll be merging this!

Yes, bumping the pip version is definitely on my personal ToDo list! Well the ToDo list is worryingly long, but I'm feeling a tiny bit more productive this week so I have hope that it will be bumped by the end of the week. Fingers crossed!