greeny / SatisfactoryTools

Satisfactory Tools for planning and building the perfect base.
https://www.satisfactorytools.com/
MIT License
268 stars 57 forks source link

Alumina Solution recipe has the incorrect amount of water #78

Closed barryfl closed 1 year ago

barryfl commented 2 years ago

In this example some of the water for producing the alumina solution comes from a later stage in the process, I think it might help to color those arrows differently or otherwise denote that relationship more obviously than just drawing the arrow tip on both ends.

(it would also be consistent with how inputs/machines/outputs are differently colored at the moment)

image

greeny commented 2 years ago

Yeah, I've seen this "issue" pop up a few times already. It's pretty common thing to happen for aluminum setups, so I think it makes sense to somehow display that. I thought the double-sided arrow with two tooltips would be fine. I'm not sure how much I like having colored arrows, I'd have to test how that looks and find a nice balance between looking good and not being too distracting.

Since I'm currently working on rewriting majort parts of the tool and this is kinda minor thing, I'll leave this to later when I have time to deal with it. Thanks for the report though!

alexanderpas commented 2 years ago

Might I suggest 2 curved arrows, with seperate labels on each arrow in order to seperately depict each direction seperately.

Something like the relation between Node 5 and Node 7 in this example: https://graphviz.org/Gallery/directed/fsm.html

C80 commented 1 year ago

Perhaps it should be noted that this seems to have been addressed in commit feb7d2d4046c32f7d90b00be66763157db34d8ed from Dec 8, 2021? :-)

      if (edge.to.hasOutputTo(edge.from)) {
          smooth.enabled = true;
          smooth.type = 'curvedCW'
          smooth.roundness = 0.2;
      }

image

greeny commented 1 year ago

yeah, sorry, I haven't really put much time into closing existing issues. I'm also working on a new tool so I don't have too much time now. Anyway, closing as fixed in feb7d2d