search

greese / dasein-cloud-openstack

Dasein Cloud implementation for all OpenStack components from Bexar to the present. For more information on Dasein Cloud, see the Dasein Cloud home page at https://github.com/greese/dasein-cloud.
https://github.com/greese/dasein-cloud
Apache License 2.0
4 stars 13 forks source link

[bugzid:4792] Added a missing remove method to NovaImage #79

Closed oldpatricka closed 10 years ago

oldpatricka commented 10 years ago

The remove(@Nonnull String providerImageId) method is used by DCM, and doesn't seem to be implemented in dasein-cloud-openstack. This PR adds support for it by calling the previously implemented remove(@Nonnull String providerImageId, boolean checkState) method.

daniellemayne commented 10 years ago

that method should not be required.

You are correct that the openstack driver does not have a specific implementation for it, but the abstract class does and it should automatically call the other method with the same parameters.

i don't understand why adding that method makes a difference

https://github.com/greese/dasein-cloud-core/blob/2014.05/src/main/java/org/dasein/cloud/compute/AbstractImageSupport.java#L379-L382

oldpatricka commented 10 years ago

Danielle is right. This doesn't seem to matter. Not sure why it seemed to...