Closed donniebishop closed 8 years ago
Hi, thanks for the report. You are correct, it does this for not only Korean, but Chinese results too. I'll be pushing out a new version with foreign language support later today and then it at least won't happen on regular (default english) searches anymore. I'll debug the non-Latin character issue afterwards. Thanks again for the heads up!
It seems that there was an issue with the inquirer library. It should be fixed now. Can you update, test and confirm?
I haven't updated the readme yet, but I pushed the multi-language support feature so you won't actually find any Chinese or Korean results in a default (English) search anymore. To get those results, run awman
with the -l korean
option (or chinesesim or chinesetrad)
Awesome! Great turnaround time.
Away from my VM at the moment, but will test tonight once I get into work.
On Mon, Feb 15, 2016 at 1:17 PM, greg-js notifications@github.com wrote:
It seems that there was an issue with the inquirer library. It should be fixed now. Can you update, test and confirm?
I haven't updated the readme yet, but I pushed the multi-language support feature so you won't actually find any Chinese or Korean results in a default (English) search anymore. To get those results, run
awman
with the-l korean
option (or chinesesim or chinesetrad)Reply to this email directly or view it on GitHub: https://github.com/greg-js/arch-wiki-man/issues/2#issuecomment-184333198
Sorry about the wait, but I have confirmed that it's working properly now. Thanks again for the quick response!
Whoops! For what it's worth, there was another bug in the menu formatting causing some entries to mysteriously lose the first [
bracket. Turns out I'd misplaced a parenthesis somewhere! I'll push the fix later today but thanks again for the bug report, it's brought several things to light already :)
When searching for "python" and scrolling through the multiple results, awman will prepend another line to the beginning of the search results to "Select the Arch Wiki article".
This seems to work fine when searching other general terms and getting back multiple responses, such as "install":
I don't have any experience in debugging, but if I had to guess, maybe it's the way that the result in Korean is being handled by the program? I can't think of another thing to search up that would return a result specifically in Korean, but it's a thought.