search

greg7mdp / parallel-hashmap

A family of header-only, very fast and memory-friendly hashmap and btree containers.
https://greg7mdp.github.io/parallel-hashmap/
Apache License 2.0
2.47k stars 234 forks source link

added check for <shared_mutex>, made Throw() a macro #185

Closed ilobilo closed 1 year ago

greg7mdp commented 1 year ago

Why make Throw a macro?

ilobilo commented 1 year ago

Because with a macro std::*_error objects will not be constructed unless exceptions are enabled. (and those classes are not implemented where I use this project)

greg7mdp commented 1 year ago

Thanks for the issue and input. I was not able to accept your PR as is, because it did not compile (see checks above), so I made Throw a macro, but with a more specific name. I also improved the check for <shared_mutex>. Also please avoid whitespace changes next time.

ilobilo commented 1 year ago

Thanks