search

gregchiasson / warhams

nerds
35 stars 17 forks source link

Unpacking a rosz file properly #22

Closed Krizzzn closed 4 years ago

Krizzzn commented 4 years ago

Unpack uploaded rosz file to a directory, searching for the first ros file, and moving it back to the /tmp folder. Cleaning up afterwards.

(I could not test the parsing on of the file on my machine, because of a missing dependency of image magick, but i think the rest of the app should work)

Krizzzn commented 4 years ago

I had the thought that the zip unpacker should probably be validating user input. Also I broke out the upload component into an own file so that it can be reused on the Killteam part.

I didnt test the killteam part (because of missing image magick). Please look at it before merging it in.