gregdardis / stock-market-search

Search a stock symbol to receive a graph and financial metrics
MIT License
5 stars 0 forks source link

integration tests for root reducer #165

Closed gregdardis closed 6 years ago

gregdardis commented 6 years ago

https://github.com/reduxjs/redux/issues/1412

had a hard time decoupling tests from child reducer implementation details.

In his example, he says action: { type: INCREMENT } but this doesn't actually change anything so how does he know the reducers received the action?.

Anyways my other idea was to simply export the object we are passing to combineReducers and make sure it includes the reducers we are expecting, and leave it at that. This (integration) test may be overboard.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 197


Totals Coverage Status
Change from base Build 174: -4.2%
Covered Lines: 279
Relevant Lines: 457

💛 - Coveralls