Settings are not stored or correctly loaded when reopening the dialog

gregdavill / KiBuzzard

MIT License

425 stars 33 forks source link

Settings are not stored or correctly loaded when reopening the dialog #32

Closed robin7331 closed 3 years ago

robin7331 commented 3 years ago

It would be nice if the settings would be stored to disk when closing the dialog with Ok. Right now I have to reenter every value when I like to do many similar labels.

I see loadConfig() and saveConfig() I the dialog.py file. I may misinterpret their intended behavior but if those are supposed to store/load those settings it may be a bug. Because that is not working on my machine.

@gregdavill is that a bug or is there nothing like that implemented?

gregdavill commented 3 years ago

You're right, there are those functions.

They should work as you describe, but they're not 100% connected and working yet.

robin7331 commented 3 years ago

Alright. Just wanted to make sure. So this is also not working properly on your side? Or is it a macOS thing again? Might look into it today and submit a PR if I get it to work.

gregdavill commented 3 years ago

Hopefully this commit will fix this :)

robin7331 commented 3 years ago

Fixed! ✌️