search

gregdavill / KiBuzzard

MIT License
425 stars 33 forks source link

Svg2Mod Update and python 2 support #72

Closed Sodium-Hydrogen closed 2 years ago

Sodium-Hydrogen commented 2 years ago

Svg2mod recently released a new version with some performance improvements. svg2mod/svg2mod#43

From my understanding Kicad v6 only uses python 3 now.

Is KiBuzzard committed to continue to release versions for both kicad 5.1 and 6?

If so I will update the python2 branch of svg2mod to be up to date with the latest changes.

Just an FYI the main file in svg2mod was getting very large so I split it into 4 new files.

gregdavill commented 2 years ago

Moving forward now that v6 is out, I think we can make the switch to drop 5.1 support at some point.

I've got some features that I think can be implemented before updating svg2mod so that these features could be available to 5.1 users.

Thanks for letting me know about the update. I think it'll be good to update! Since KiBuzzard makes pretty heavy use of svg2mod for rendering.

Sodium-Hydrogen commented 2 years ago

Since you plan on adding a couple of features for 5.1 I've gone ahead and updated the python2 branch to include the latest changes so 5.1 users can have the performance improvements.

gregdavill commented 2 years ago

FYI, the way svg2mod is currently packaged with KiBuzzard, as a subtree, I've not updated it in a along while!

gregdavill commented 2 years ago

I've pulled in the newest svg2mod code and in https://github.com/gregdavill/KiBuzzard/commit/980be7839a3bdb56437a147e9bbae75f5b5edae4 I've updated KiBuzzard with code changes needed for this.

I've also dropped KiCad v5 support. Mostly due to it making use of python 2. (Users of v5 should use the 1.0.0 or 1.1.0 releases of KiBuzzard.)