search

gregersrygg / crapLoader

Asynchronous script loader/runner for ads, widgets and other third-party content
71 stars 10 forks source link

Call to AdTech ends up delivering two ads instead of one #7

Closed spil-peter-lorent closed 12 years ago

spil-peter-lorent commented 12 years ago

With AdTech as our main ad provider we are having issues with multiple calls within the same page. The call to AdTech has a parameter for the creative size - for instance 225 for a 728x90, 170 for a 300x250. If the first call on the page is a 300x250 and the second one a 728x90, we end up with two 300x250 ads, with one of them ending up in the container for the 728x90 ad. And I'm unable to figure out yet why this is happening. I can provide you with a test page but I can't post the calls here publicly. If you want, I can mail you the test page. My email: peter dot lorent and it is a gmail account. Otherwise, you can maybe give me some pointers where I should start looking in the craploader script.

gregersrygg commented 12 years ago

Sorry I didn't get back to you earlier. Are you still having this issue?

crapLoader doesn't do any resizing of elements, so from where do the banners get their size?

How do you use crapLoader?

Are the correct banner output in the correct container?

Do you resize the container in the success callback?

Could you try disabling parallel loading?

// call hijack manually to disable parallel loading
crapLoader.hijack({parallel: false});

// load scripts
crapLoader.loadScript(...);
plorent commented 12 years ago

Hi, thanks for responding. I think I overlooked the available option to set parallel loading to false. The issue was related to not locking document.write until an ad was completely parsed. I'll try to use the parallel loading option.

plorent commented 12 years ago

Hmm, I had a quick look at my tests and I was using parallel:false. There is no resizing going on. If I have three consecutive loadScript() calls I just end up with banners in the wrong containers like described above. I'll see if I can assemble a test.

gregersrygg commented 12 years ago

In which browsers is this happening?

plorent commented 12 years ago

I've been testing in Safari/Chrome (Mac) mostly.

gregersrygg commented 12 years ago

Hmm, haven't seen problems with parallel loading on other than IE. Can you please send me a url or test example on email? I use the same username at gmail. Thanks :)

plorent commented 12 years ago

Sure thing, I'll send you a test page asap.

plorent commented 12 years ago

Is your location Norway?

gregersrygg commented 12 years ago

Yes, Oslo

gregersrygg commented 12 years ago

Haven't seen any mail yet, so closing this issue. Can re-open if necessary.