search

greggles / mcc-codes

A public repository of Merchant Category Codes (MCC) in formats easier to read than most places (i.e. not a PDF)
The Unlicense
472 stars 294 forks source link

Update MCC codes and documentation #22

Closed clandinq closed 1 year ago

clandinq commented 1 year ago

Hi Greg,

First of all, thanks for your work on this repo. It's been really useful to me so far.

I'm working on an MCC-ISIC code mapping so I wanted to make sure the codes were updated. I updated the CSV (I didn't generate the other files) and included a documentation folder:

  1. Add missing codes. I went over the issue raised by jleclanche and compared three of the mappings he shared with the current list of codes. I incorporated missing codes from the official ISO list and VISA list (adding 49 codes).
  2. Remove redundant variable. I removed the variable combined_description, since it was equal to edited_description, and renamed edited_description to mcc_description.
  3. Create MCC category variable. I generated a new variable called mcc_category, incorporating the categories shared by jleclanche and the categories found in the Citibank MCC code list. Categories described as "reserved" were omitted from this list.
  4. Include documentation. Finally, I added a documentation folder with the Citibank, Mastercard and Visa PDFs with MCC codes.

Hope this is useful and tell me if any changes are needed.

clandinq commented 1 year ago

I realized that there a few more MCC codes contained in the Citibank PDF that could be added to the list. I'm closing the pull request for now, but message me if you'd like me to do it again.

greggles commented 1 year ago

Sorry for the delayed response.

  1. Seems great! Would love to have these.
  2. I think another issue is already working on that. It seems like a good idea, though.
  3. OK, yes, seems good.
  4. I think we shuld include links, perhaps in the README, but not the actual files as I assume they are licensed in a way that doesn't allow copying and redistributing.