Opinions on awesomeness

gregglind / shield-study-embedded-web-extension-example

0 stars 1 forks source link

Open gregglind opened 7 years ago

gregglind commented 7 years ago

Is this actually good?

gregglind commented 7 years ago

@groovecoder @osmose @raymak trying to figure out the exact rightest things here.

gregglind commented 7 years ago

My opinions:

for now, no startup, shutdown etc functions.
jsonschema validation is a YES, and we need to pull in / build ajv
duration timers... are not in this round and can wait. they require storage of firstrun. I would rather solve this using external clocks ONCE AND FOR ALL, rather than relying on js Date(). All turn off is explicit.

Osmose commented 7 years ago

I think the overall shape is a lot closer to what's in my head as the ideal study lib design than the previous libs. 👍

At this point I don't think I have any more substantial feedback than that.