search

greggman / virtual-webgl

Virtualize WebGL Contexts
Other
149 stars 12 forks source link

Provide lower case extensions #7

Closed archmoj closed 1 year ago

archmoj commented 1 year ago

I was testing this great library with multiple plotly.js graphs. Since regl passes lower case extension names, adding these lines can help resolve getting missing methods.

greggman commented 1 year ago

thanks!

I fixed it a different way. v1.0.4 https://github.com/greggman/virtual-webgl/commit/7f43c55595e1ba03017e2b1ccc38f836af255d3c

Hopefully it works for you

archmoj commented 1 year ago

thanks!

I fixed it a different way. v1.0.4 7f43c55

Hopefully it works for you

@greggman I am still using webgl version 1. Would you possibly fix that for v1 as well? Or do you want me to submit a PR similar to https://github.com/greggman/virtual-webgl/commit/7f43c55595e1ba03017e2b1ccc38f836af255d3c? Thank you!

archmoj commented 1 year ago

I am using this file for webgl v1: https://github.com/greggman/virtual-webgl/blob/master/src/virtual-webgl.js Would you please fix that one too? :pray:

greggman commented 1 year ago

uploaded v1.0.5

archmoj commented 1 year ago

Thank you very much!