search

greghope667 / square-off-remote

GNU General Public License v3.0
1 stars 2 forks source link

Add experimental stream of finished games from broadcasts to Square Off GKS using Lichess API #5

Closed eqikkwkp25-cyber closed 7 months ago

eqikkwkp25-cyber commented 8 months ago

Add experimental stream of finished games from broadcasts to Square Off GKS using Lichess API

greghope667 commented 7 months ago

Thanks for the PR. Apologies for the delay in reviewing this, I've been away over the holidays and didn't have the board to test with.

The code works for me, I'm able to watch games from Lichess successfully. It's pretty great to watch too, I'm definitely going to use this while watching some tournaments. There's a few additions we could make (e.g. better handling of watching live games) but that's possibly for another PR.

In terms of code quality this looks fine to me. Personally I care more about whether code works than how it looks, so I don't really have any comments to make on style. The code could probably be split up into functions but that's not essential for a small script like this. I'm happy to merge this as-is (unless you want to add anything extra).

Again, thanks for the contribution.

eqikkwkp25-cyber commented 7 months ago

No problem about the late reply and there are no obligations. Any new features or improvements are kind of a goodie for me and cool that you're already using the code.

I had made a small modification as the "Event" header for the games I tested already contained the player names, but there are obviously some without this information.

You are welcome to add the code in this state.

As for the live events: Not trivial at first, as the complete round of a broadcast is streamed as a PGN, i.e. you first have to create a list to select the game (already in the current code) and then parse the stream again appropriately for changes to the selected game and execute the moves? I'll have to look at the API again in detail.