search

gregkh / usbutils

USB utilities for Linux, including lsusb
http://www.linux-usb.org
356 stars 202 forks source link

Add files via upload #101

Closed burki-de closed 4 years ago

burki-de commented 4 years ago

Hello Greg,

thank you for your description how to send patches ;-)

I added a new option -f to lsusb to be havea more flexible list format and to be able to print the serial number in hexadecimal. Reason is, that I've several ST-Link/V2 programmer, which use binary data for serial number string :-( Now I can switch to the hex dump and can grep the device I'm looking for ;-)

burki-de commented 4 years ago

Hello Greg,

You asked me about a "signed-of-by". Read about what it is but don't find a place to add it somewhere in github and I think to put it somewhere into the source is a bad idea. So I made a short, one line text file with my "signed-of-by" and added it. Hope you can put it to the right place. If not it would be great when you give me a hint how to handle. Greetings from Germany

Burkhard

gregkh commented 4 years ago

Please rebase your changes such that you have unique commits with different changelog texts that do not all have the same subject, and you remove the ones that are not needed.

As for the signed-off-by, that goes in the changelog text, look at all of the other commits in this tree for examples of how to do that (do a 'git log' on the repo).

If you clean that all up, and make a set of patches that only do one logical thing per commit, I'll be glad to review them.

gregkh commented 4 years ago

Closing due to slow response. Please feel free to fix up and resubmit and I will gladly review.

thanks!