search

gregkh / usbutils

USB utilities for Linux, including lsusb
http://www.linux-usb.org
356 stars 202 forks source link

Some fixes for printing endpoints and interfaces by usb-devices #118

Closed 10110111 closed 3 years ago

10110111 commented 3 years ago

First commit fixes presence detection detection of endpoint-related information, and the others fix formatting of various fields of I: and E: lines, so that the parsers don't misinterpret them.

gregkh commented 3 years ago

Can you add some better changelog comments on these, and a proper signed-off-by so I can accept these changes?

10110111 commented 3 years ago

By changelog I suppose you mean commit messages, right? In that case I'm not sure how "some better" should look. More detailed—like "use %2i instead of %2s"? Or something else?

gregkh commented 3 years ago

"better" meaning "describes what is happening and why this change is here", like kernel commit changelogs are.

And a proper signed-off-by line as well, again, like the kernel uses. thanks!

10110111 commented 3 years ago

I've added some descriptions to the commit messages, and followed the GitHub DCO's suggestions on fixing the signoff.

gregkh commented 3 years ago

Much better, thanks! One minor comment above.

gregkh commented 3 years ago

Thanks, look much better!