Closed naruto-abc closed 1 year ago
Can you split this into 2 different patches, one that does one thing, and the other doing the other? A good change should only do one thing at a time, making it easier to review and understand.
Hi Greg,
I've split it into two commits and added more explanation for each one. You can still refer to the screenshots in this pull request, which is more straightforward to show the effects.
Thanks for the fixes, looks good.
First issue, I found there is a weird line:
This because an unsigned int type is used to hold a potential negative value. In order to fix it, I change some variable type to int. I think int type is also safe to hold the values without overflow. After fixing it:
Second issue, an unalignment for string "Report Descriptors":
After fixing it: