gregkh / usbutils

USB utilities for Linux, including lsusb
http://www.linux-usb.org
354 stars 199 forks source link

ci(lint): add shell linter - Differential ShellCheck #166

Closed jamacku closed 1 year ago

jamacku commented 1 year ago

Differential ShellCheck is a GitHub Action that performs differential ShellCheck scans on shell scripts changed via PR and reports results directly in PR.

Since you have a few shell scripts, I think you might find the differential-shellcheck Action useful. It is able to produce reports in SARIF format. GitHub understands this format and is able to display it nicely as a PR comment, and on the Files Changed tab, please see below.

image

image

Documentation is available at @redhat-plumbers-in-action/differential-shellcheck. Let me know If you are missing some feature or setting. I'm always happy to extend functionality.

gregkh commented 1 year ago

Thanks for the offer, but we do not have any .github specific things in this repo for good reason.

Feel free to run shellcheck on the source and submit patches if you feel they are needed.