usb-devices: make shellcheck happy

gregkh / usbutils

USB utilities for Linux, including lsusb

http://www.linux-usb.org

354 stars 199 forks source link

Closed lnykryn closed 1 year ago

lnykryn commented 1 year ago

This change should not make any difference in behavior, but fixes all shellcheck warnings besides https://www.shellcheck.net/wiki/SC3043

Also replacing 'var=cat file' with 'read' makes usb-devices much faster.

Old: real 0m0,849s user 0m0,388s sys 0m0,531s

New: real 0m0,245s user 0m0,109s sys 0m0,155s

gregkh commented 1 year ago

Looks good, thanks for the cleanups!