search

gregkh / usbutils

USB utilities for Linux, including lsusb
http://www.linux-usb.org
354 stars 199 forks source link

Fix usb-devices to work under busybox #181

Open fancsali opened 8 months ago

fancsali commented 8 months ago

The previous implementation relied on the -printf option for find, which is not implemented in BusyBox.

Replaced it with sed to find the basenae of files reliably.

gregkh commented 7 months ago

As the bot says, you need to sign off on your change :(

fancsali commented 7 months ago

@gregkh, thanks for reminding me.

Just to confirm, what exact meaning do we attach to a commit being signed-off in this project?

fabioestevam commented 7 months ago

@gregkh, thanks for reminding me.

Just to confirm, what exact meaning do we attach to a commit being signed-off in this project?

You need to add the following line to your path:

Signed-off-by: Your Name

See the other commits as references.

gregkh commented 7 months ago

On Wed, Jan 17, 2024 at 03:21:46PM -0800, fabioestevam wrote:

@gregkh, thanks for reminding me.

Just to confirm, what exact meaning do we attach to a commit being signed-off in this project?

You need to add the following line to your path:

Signed-off-by: Your Name

See the other commits as references.

That says what to do, but not what it means :)

This is following the DCO as created by the Linux kernel project, and I'll document it better later today so as it makes more sense what you are agreeing to when you add this line of text.

thanks,

greg k-h

fancsali commented 6 months ago

@gregkh, did you, by any chance, get the opportunkty to update the documentation on this, please?