search

gregkorossy / Android-Support-Preference-V7-Fix

Android androidx.preference support library has some issues, this lib tries to fix them.
https://discord.gg/87NVsSK
Apache License 2.0
497 stars 46 forks source link

Hidden divider API in support library #111

Open Mygod opened 6 years ago

Mygod commented 6 years ago

I just discovered that there're app:allowDividerAbove and app:allowDividerBelow APIs. Is it possible to use these?

gregkorossy commented 6 years ago

Where do you see these attributes?

Mygod commented 6 years ago

It's in the decompiled Preference class.

gregkorossy commented 6 years ago

Technically, I think it would be possible to use these values as these are used in the view holder but it would be difficult to tell when should these override the divider flags.

Mygod commented 6 years ago

In 28.0.0-alpha3, these attributes are being actively used as such:

        <item name="allowDividerAbove">false</item>
        <item name="allowDividerBelow">true</item>
        <item name="iconSpaceReserved">@bool/config_materialPreferenceIconSpaceReserved</item>