search

gregkorossy / Android-Support-Preference-V7-Fix

Android androidx.preference support library has some issues, this lib tries to fix them.
https://discord.gg/87NVsSK
Apache License 2.0
497 stars 46 forks source link

Update library for 28.0.0-alpha3 #171

Closed Mygod closed 6 years ago

Mygod commented 6 years ago

P.S. It seems like most (if not all) code in this library isn't about FIX anymore.

gregkorossy commented 6 years ago

This lib still fixes some issues, e.g. the preference category color not being set to the accent color on pre-lollipop devices.

Mygod commented 6 years ago

I just noted that a few days back Google released androidx 1.0.0-beta01 without updating the old library to 28.0.0-beta01. I think it's time to upgrade in which case we can delete whatever we want.

gregkorossy commented 6 years ago

The androidx version will reside in a new repo with new artifact names so that's a different story. The 28.0.0 version will be the last stable version of the support lib so this artifact of the lib (28.0.0.x) will live till that.

Mygod commented 6 years ago

@Gericop I don't see any progress on that. Have you started working on the new repo? I can start porting code now. What do you think of com.takisoft.preferencex?

gregkorossy commented 6 years ago

I haven't started working on it yet, only created the repo (lol). That name sounds good to me. I can add you as a collaborator to the repo so you can push the code there if you want.

Mygod commented 6 years ago

Hmm I already started changing code in this repo. I think it would be easier than starting a new repo and copying things there.

gregkorossy commented 6 years ago

Then keep changing it here on a new branch (devX maybe?) and that branch will be committed to the new repo.

Mygod commented 6 years ago

Okay. Closing this for now.