search

gregkorossy / Android-Support-Preference-V7-Fix

Android androidx.preference support library has some issues, this lib tries to fix them.
https://discord.gg/87NVsSK
Apache License 2.0
497 stars 46 forks source link

Upgrade to support library v25.3.0 #67

Closed gregkorossy closed 7 years ago

gregkorossy commented 7 years ago

No support preferences related changes.

gregkorossy commented 7 years ago

Released v25.3.0.0.

zhanghai commented 7 years ago

They say SwitchCompat animation is fixed and released 25.3.0; is our fix still needed?

gregkorossy commented 7 years ago

It's fixed indeed, good catch! I checked the AOSP issues for 25.3.0 fixes, but found none. I guess they had not updated it yet by that time I checked it. Looking at the class, I found a really annoying thing though: SwitchCompat is now targeted for API 14 and over, which should not be the case as per the docs stating it's ported back to v7, and now the v7 (or v9 in their statements) SwitchPreferenceCompat doesn't work.

gregkorossy commented 7 years ago

Okay, so 25.3.0 removed the support of API 13 and lower devices, 25.3.1 added it back again, but it seems to me that they just used an earlier commit since the switch animation is not happening again... Well, I'm gonna use the custom implementation for 25.3.x, then I guess 26.0.0 drops the < API 14 support anyways, so the animation will work on its own...