gregkorossy / DateTimePicker

Material themed DateTimePickers from the Android framework for all API levels (API 14+)
Apache License 2.0
73 stars 17 forks source link

Add set color method #3

Closed tcqq closed 6 years ago

tcqq commented 6 years ago

Add method for datepicker:

Add method for timepicker:

gregkorossy commented 6 years ago

The only problem with this is that this repo is basically a dependency mirror for the latest release of the native date-time picker dialogs. This means that if a new major version gets released, the whole lib might get replaced entirely instead of adding individual code blocks because the removal / addition of internal API substitutes is easier (yet cumbersome) than editing the existing solution. So in the future it is possible that these methods get removed and need to be re-added. Also, just like you cannot change theming in an AlertDialog dynamically, it seems a bit weird to me to add it here.

tcqq commented 6 years ago

Thanks, I understand, but in order for the app to display properly under multiple themes, I had to programmatically change its color.