search

greglook / clj-cbor

Native Clojure CBOR codec implementation.
The Unlicense
70 stars 7 forks source link

Report type when erroring on unsupported-type #15

Closed Kristjansson closed 4 years ago

Kristjansson commented 4 years ago

When logging the value, it's not always clear the exact type that's causing failure (ArrayList vs vec for example). Adding the type makes this error message a little more informative.

codecov-io commented 4 years ago

Codecov Report

Merging #15 into master will decrease coverage by 1.8%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage     100%   98.19%   -1.81%     
==========================================
  Files          13       13              
  Lines         811      831      +20     
  Branches        0        4       +4     
==========================================
+ Hits          811      816       +5     
- Misses          0       11      +11     
- Partials        0        4       +4
Impacted Files Coverage Δ
src/clj_cbor/codec.clj 100% <100%> (ø) :arrow_up:
src/clj_cbor/data/simple.clj 28.57% <0%> (-71.43%) :arrow_down:
src/clj_cbor/data/tagged.clj 50% <0%> (-50%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 875784b...b1af7fc. Read the comment docs.