search

greglook / cljstyle

A tool for formatting Clojure code
Eclipse Public License 1.0
293 stars 39 forks source link

Handle ns attr-map [#50] #51

Closed tobias closed 4 years ago

tobias commented 4 years ago

This is my attempt to resolve #50. It's not yet correct, since the indentation for the map is wrong (the failing test is testing for what I believe should be the correct format), but I wanted to put up what I had so far for discussion.

This currently formats:

(ns foo
      {:foo :bar 
   :baz true})

As: 

(ns foo
  {:foo :bar 
 :baz true})

Instead of:

(ns foo
  {:foo :bar 
   :baz true})

What do I need to change to have this format correctly?

codecov-commenter commented 4 years ago

Codecov Report

Merging #51 into master will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   92.70%   92.75%   +0.05%     
==========================================
  Files          13       13              
  Lines        1521     1533      +12     
  Branches       44       44              
==========================================
+ Hits         1410     1422      +12     
  Misses         67       67              
  Partials       44       44
Impacted Files Coverage Δ
src/cljstyle/format/ns.clj 96.76% <100.00%> (+0.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b44e0d6...865ed17. Read the comment docs.

tobias commented 4 years ago

Thanks for merging @greglook. Do you have any idea of when you be able to cut a new release?

greglook commented 4 years ago

I was hoping to get a few more features and issues resolved before the next release, but I'll get something out by the end of the week.

tobias commented 4 years ago

Thanks Greg!

On Thu, Jun 11, 2020 at 5:49 PM Greg Look notifications@github.com wrote:

I was hoping to get a few more features and issues resolved before the next release, but I'll get something out by the end of the week.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.