tagged-literal warnings with Clojure 1.7.0-beta1

greglook / puget

Canonical Colorizing Clojure Printer

The Unlicense

252 stars 27 forks source link

tagged-literal warnings with Clojure 1.7.0-beta1 #20

Closed xpe closed 9 years ago

xpe commented 9 years ago

I use ultra. I get these warnings with [mvxcvi/puget "0.7.1"] with [org.clojure/clojure "1.7.0-beta1"]:

WARNING: tagged-literal already refers to: #'clojure.core/tagged-literal in namespace: puget.data, being replaced by: #'puget.data/tagged-literal
WARNING: tagged-literal? already refers to: #'clojure.core/tagged-literal? in namespace: puget.data, being replaced by: #'puget.data/tagged-literal?

greglook commented 9 years ago

Yeah, this needs to be updated for Puget to use the built-in tagged-literal code in 1.7.

xpe commented 9 years ago

I took a look at the code -- it didn't like a trivial change (at least for me to knock out quickly).

greglook commented 9 years ago

@xpe see the referenced commit - this code wasn't actually being used much. Once 1.7 is stable I should extend the ExtendedNotation protocol to the built-in TaggedLiteral type.