venantius
commented
8 years ago I have some thoughts:
- JavaScript does not have an inheritance model in the same way that Java does. We can check that a given object satisfies an interface, for instance, but there isn't really chained inheritance the way there is in Java.
- Checking for basic types is obviously going to be different. We would dispatch on
js/Numberrather thanjava.lang.Integeretc. - I find the
puget.dispatchnamespace confusing.
I don't really understand how the library works right now, so just at a high level I'd like some clarification that I really understand what's going on. My understanding of the code is as follows:
- We have various maps, for instance,
puget.printer/java-handlers, where the keys are references to classes and the values are the print-functions - When we try to call
dispatchon a value, it looks up the corresponding value for its key in the map based on the results of a call toclasson the value, and calls that on itself to try to print the value. If it can't find anything it falls back to a default print method ofjava.lang.Object
It would seem to me that since class doesn't exist in ClojureScript, we'd end up adopting a very different approach - one based first on checking type, and then after that using satisfies? to check against known interfaces (possibly). Unlike in Java, we don't have the option of calling, .getInterfaces on the class itself.
Thoughts @greglook ?
greglook
This is just a start; there's a bunch of stuff that'll need to be changed and I wanted to go through some of it in a somewhat interactive form rather than going too far down the rabbit hole and finding out that wasn't a direction we agreed on.