search

greglook / whidbey

nREPL middleware to pretty-print colored values
The Unlicense
158 stars 10 forks source link

Incompatible with CIDER 0.8.0-SNAPSHOT #7

Closed maravillas closed 10 years ago

maravillas commented 10 years ago

If I have [mvxcvi/whidbey "0.3.2"] in my profile.clj, I get odd behavior from CIDER's default namespace: https://www.refheap.com/89106

I suspect this is also true for CIDER 0.7.0, but I haven't tested it.

greglook commented 10 years ago

Unfortunately I'm not an emacs user, so I'm not sure where to start debugging this. I'll do some research into CIDER to see how it works, but I'll probably need help here.

I'm also going to be quite busy for the next few weeks, so it may be sometime in September before I get to this.

gfredericks commented 10 years ago

I believe this is the result of the "ugly" code at the bottom of whidbey's middleware.

Whidbey relies on the builtin pr-values middleware not being present, and the code above tries to accomplish this by removing interruptible-evals reference to it. Unfortunately this doesn't prevent any other middleware from referencing pr-values and thereby re-enabling it, and as far as I understand nrepl middleware this is a totally reasonable thing to do. In particular cider-nrepl does it.

I'm pondering what the best way to address this is. It seems a strange weakness in nrepl.

gfredericks commented 10 years ago

I just created #13 so this can be tracked a little more directly.

greglook commented 10 years ago

Should work with 0.4.0 (see #10).