gregmoille / pyLLE

Lugiato Lefever Equation Solver in Python/Julia
Other
65 stars 39 forks source link

some parameter issues #24

Closed unknownfox71 closed 2 years ago

unknownfox71 commented 3 years ago

Hello l have successfully run the code, but, i have some confusion about parameter you setting in ComputeLLE.jl

Thanks for your answer. Kind regards, LiChenhong

gregmoille commented 3 years ago

Hi,

First of, that’s god news you manage to get the code runing 😊

unknownfox71 commented 3 years ago

Hello, Thank you so much, and I checked that the integrated dispersion is indeed mutiplied by tR, and, i just finded that before the iteration, the intergrated dispersion Dint*tR, and then divided by L, What is this mean? I mean, L is the length of cavity, why the normalized intergrated dispersion is divided by L. Thanks again.

gregmoille commented 3 years ago

Sorry about the confusion about the Dint normalize with the cavity length. Historically, there way I coded the core script was using the phase difference (or the β coefficient) instead of the integrated dispersion, which yields a slightly different formula than the Dint (see line 107 of _analysedisp.py). From the phase shift, one could easily extract the β, from which in the LLE the path length has to be taken into account. The funny thing is that the phase and β are the same except the normalisation of the length (see line 116 of the julia core and the line 206 ). I agree this is a bit confusing and a new version of the code I am currently working on will clear up a lot of this mess, yet we are still in the process of publishing experimental/simulation results so I won’t push it on github just yet.