search

gregmuellegger / django-autofixture

Can create auto-generated test data.
BSD 3-Clause "New" or "Revised" License
460 stars 118 forks source link

Added examples to the readme, along with cleaning it up a bit. #85

Closed DanHitt closed 8 years ago

DanHitt commented 8 years ago

This saved me a ton of time, thanks a lot! Hope these small changes help someone else new.

DanHitt commented 8 years ago

Sorry, accidently sent you some other changes which you can discard.

gregmuellegger commented 8 years ago

Thanks a lot for the improvements! I added a few inline comments for things that need adjustment before I can merge it.

DanHitt commented 8 years ago

Sure, yeah, whatever you think is best. Thanks for letting me help.

On Thu, Mar 24, 2016 at 3:10 PM, Gregor Müllegger notifications@github.com wrote:

Thanks a lot for the improvements! I added a few inline comments for things that need adjustment before I can merge it.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/gregmuellegger/django-autofixture/pull/85#issuecomment-201022054

DanHitt commented 8 years ago

I'd delete it if you don't have plans for a more detailed readme.

However, when I use it in the future I could add more examples...which are the main things new users really need.

On Thu, Mar 24, 2016 at 3:20 PM, Dan Hitt d.hitt424@gmail.com wrote:

Sure, yeah, whatever you think is best. Thanks for letting me help.

On Thu, Mar 24, 2016 at 3:10 PM, Gregor Müllegger < notifications@github.com> wrote:

Thanks a lot for the improvements! I added a few inline comments for things that need adjustment before I can merge it.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/gregmuellegger/django-autofixture/pull/85#issuecomment-201022054

gregmuellegger commented 8 years ago

I merged this but cleaned up the commit before hand so that no sublime specific stuff are in the history, that's why this PR is not marked as merged. Here is your commit in the project: https://github.com/gregmuellegger/django-autofixture/commit/f8fcd0d0ac05031a635eee8f7f3c16ff29e40ad4

Thanks for the work you have put in! This will be part of a new release that goes out today.

gregmuellegger commented 8 years ago

Cheers, your patch is in the new release: https://pypi.python.org/pypi/django-autofixture/0.12.1

DanHitt commented 8 years ago

sweet! thanks!

On Fri, Apr 8, 2016 at 1:54 AM, Gregor Müllegger notifications@github.com wrote:

Cheers, your patch is in the new release: https://pypi.python.org/pypi/django-autofixture/0.12.1

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/gregmuellegger/django-autofixture/pull/85#issuecomment-207286169